You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: use one pnpm pin throughout the workspace - #479
Running Corepack from a workspace package currently selects its stale pnpm 9.15.5 pin instead of the root's pnpm 11.1.0 pin. This removes the ten nested pins so every workspace uses the single existing root version.
The pnpm 11.9 upgrade and minimum-release-age policy are separate proposals. Neither is needed to fix directory-dependent version selection, and neither is included in the final diff.
AI review notes:
Validation:
Actual Corepack selected pnpm 11.1.0 at the root and in all ten workspaces, with Corepack network access disabled.
A frozen install launched through Corepack from packages/create passed without lockfile changes.
A negative control retaining a nested pin still selected pnpm 9.15.5.
Normal Husky hook passed all ten workspace builds, lint, 569 unit tests and eight blocking browser cases.
No runtime or dependency changes. Provider traffic was blocked throughout validation.
Summary by CodeRabbit
Chores
Removed the explicit pnpm version declaration from the CLI, app-creation packages, and custom CLI examples. These packages no longer specify a particular pnpm version in their metadata. The Node.js engine requirements remain unchanged where noted.
No actionable comments were generated in the recent review.
Walkthrough
The packageManager field specifying pnpm@9.15.5 was removed from ten package manifests. Other manifest fields, including the stated Node.js engine requirements, remain unchanged.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 329b1f69-c46f-45d8-b906-8f74703ed7dc
Commits
Reviewing files that changed from the base of the PR and between 4892999 and 7a962f5.
Files selected for processing: 10
cli-aliases/create-start-app/package.json
cli-aliases/create-tanstack-app/package.json
cli-aliases/create-tanstack/package.json
cli-aliases/create-tsrouter-app/package.json
cli-aliases/ts-create-start/package.json
examples/custom-cli/create-qwik-app/package.json
examples/custom-cli/create-rwsdk/package.json
examples/custom-cli/customized-react/package.json
packages/cli/package.json
packages/create/package.json
Files with no reviewable changes: 10
packages/cli/package.json
cli-aliases/create-tsrouter-app/package.json
cli-aliases/create-start-app/package.json
cli-aliases/ts-create-start/package.json
cli-aliases/create-tanstack-app/package.json
cli-aliases/create-tanstack/package.json
packages/create/package.json
examples/custom-cli/customized-react/package.json
examples/custom-cli/create-qwik-app/package.json
examples/custom-cli/create-rwsdk/package.json
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
The version mismatch is reproducible. Can we fix it by keeping one pnpm pin at the workspace root, then handle the tool upgrade and release-age policy separately?
AI review notes:
On current main, Corepack selects pnpm 11.1.0 at the root and pnpm 9.15.5 inside packages/cli and cli-aliases/create-tsrouter-app. pnpm 9.15.5 rejects the current frozen workspace lockfile with an overrides mismatch. In a disposable copy, deleting just those nested pins made both directories select the existing root version. That fixes the mismatch without needing to keep a second copy of the pin in each package.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running Corepack from a workspace package currently selects its stale pnpm 9.15.5 pin instead of the root's pnpm 11.1.0 pin. This removes the ten nested pins so every workspace uses the single existing root version.
The pnpm 11.9 upgrade and minimum-release-age policy are separate proposals. Neither is needed to fix directory-dependent version selection, and neither is included in the final diff.
Summary by CodeRabbit